handsontable / hyperformula

HyperFormula is an open-source headless spreadsheet for business web apps. It comes with over 400 formulas, CRUD operations, undo-redo, clipboard support, and sorting.
https://hyperformula.handsontable.com/
Other
1.97k stars 108 forks source link

[Bug]: Moving rows sometimes does not update formulas correctly #1339

Closed mtjoe3 closed 10 months ago

mtjoe3 commented 10 months ago

Description

Moving last row referenced in formula to the top of the formula will update formula to exclude it from the formula.

I think this makes sense if we move the row directly in one single step, but it does not if we are moving the row in multiple steps (move it to the middle of the formula first, and then to the top).

Video or screenshots

https://github.com/handsontable/hyperformula/assets/83485085/a61e849b-f941-432a-aa55-bc10e4511287

Demo

https://jsfiddle.net/fuqsmc3e/

HyperFormula version

2.4.0

Your framework

Vanilla Javascript

Your environment

MacOS

adrianszymanski89 commented 10 months ago

Hi @mtjoe3

I'm not sure if I understood your issue correctly. Can you please explain what would be your expected output here?

AMBudnik commented 10 months ago

Hi @mtjoe3 do we have any updates regarding this issue?

BrianHung commented 10 months ago

This issue should probably belong in the handsontable repo right, since hyperformula does not offer a UI for manipulating rows.

sequba commented 10 months ago

I'm not sure what behavior the issue author expects in this situation so it's hard to tell whether it's a HyperFormula issue or a handsontable one.

For now, I'm closing it due to insufficient details. @mtjoe3, please reopen the issue when you were able to provide more information.