search

handsontable / hyperformula

HyperFormula is an open-source headless spreadsheet for business web apps. It comes with over 400 formulas, CRUD operations, undo-redo, clipboard support, and sorting.
https://hyperformula.handsontable.com/
GNU General Public License v3.0
1.88k stars 107 forks source link

[Bug]: `simpleCellRangeToString` does not work with column ranges and row ranges #1375

Closed sandzone closed 2 months ago

sandzone commented 5 months ago

Description

If the range has values with entire columns or rows, simpleCellRangeToString is not giving the correct answer.

Video or screenshots

image

Demo

none

HyperFormula version

2.6.1

Your framework

No response

Your environment

node v18.7

adrianszymanski89 commented 4 months ago

Hi @sandzone

Thank you for contacting us. I wasn't able to get the same result as you. Can you please send us a code demo where the issue is replicable?

sandzone commented 4 months ago

Hi @sandzone

Thank you for contacting us. I wasn't able to get the same result as you. Can you please send us a code demo where the issue is replicable?

Thanks for the response. Here is a jsfiddle with the issue

https://jsfiddle.net/sandeep_muthangi/nsvqmbza/4/

image

adrianszymanski89 commented 4 months ago

Hi @sandzone

Thank you for the example. I'm consulting our HyperFormula developer about it and should have more information by tomorrow. I'll keep you updated.

sequba commented 4 months ago

Hi, @sandzone, thank you for reporting this issue.

Currently simpleCellRangeToString method does not work with column ranges and row ranges. We will discuss this issue with the HyperFormula team. We need to either describe this limitation in the API reference or make it work with all types of ranges.

sequba commented 4 months ago

Estimation for making simpleCellRangeToString work with all types of ranges: 3 SP.

AMBudnik commented 2 months ago

Hi @sandzone

Thank you again for your contribution to make HyperFormula better. I'm more than happy to announce that by the merge of https://github.com/handsontable/hyperformula/pull/1391 this issue made it to the 2.7.0 version, which was released today.

I'm closing this issue as done, but feel free to create a new one or write to us if you have any questions.