handsontable / hyperformula

HyperFormula is an open-source headless spreadsheet for business web apps. It comes with over 400 formulas, CRUD operations, undo-redo, clipboard support, and sorting.
https://hyperformula.handsontable.com/
GNU General Public License v3.0
1.88k stars 107 forks source link

`getNamedExpressionsFromFormula` method #1393

Closed sequba closed 3 months ago

sequba commented 3 months ago

Context

How did you test your changes?

Types of changes

Related issues:

Fixes #1365 https://github.com/handsontable/hyperformula/discussions/1077

Checklist:

github-actions[bot] commented 3 months ago

Performance comparison of head (50cce44d656359eea6143dee43e2e943a6840f32) vs base (2404ac440e57d05fe902a386feaaf557eeb29757)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 554.88 |    540 | -2.68%
                                      Sheet B | 178.86 |  177.1 | -0.98%
                                      Sheet T | 156.78 |  155.1 | -1.07%
                                Column ranges | 562.08 | 556.84 | -0.93%
Sheet A:  change value, add/remove row/column |  15.19 |  14.72 | -3.09%
 Sheet B: change value, add/remove row/column |  132.5 | 129.62 | -2.17%
                   Column ranges - add column | 152.05 | 147.56 | -2.95%
                Column ranges - without batch | 440.32 | 434.74 | -1.27%
                        Column ranges - batch | 117.66 | 112.77 | -4.16%
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.37%. Comparing base (2404ac4) to head (50cce44).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/handsontable/hyperformula/pull/1393/graphs/tree.svg?width=650&height=150&src=pr&token=5k9ZQv8azO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=handsontable)](https://app.codecov.io/gh/handsontable/hyperformula/pull/1393?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=handsontable) ```diff @@ Coverage Diff @@ ## develop #1393 +/- ## ======================================== Coverage 97.36% 97.37% ======================================== Files 169 169 Lines 14422 14428 +6 Branches 3100 3099 -1 ======================================== + Hits 14042 14049 +7 + Misses 377 376 -1 Partials 3 3 ``` | [Files](https://app.codecov.io/gh/handsontable/hyperformula/pull/1393?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=handsontable) | Coverage Δ | | |---|---|---| | [src/HyperFormula.ts](https://app.codecov.io/gh/handsontable/hyperformula/pull/1393?src=pr&el=tree&filepath=src%2FHyperFormula.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=handsontable#diff-c3JjL0h5cGVyRm9ybXVsYS50cw==) | `99.73% <100.00%> (+0.13%)` | :arrow_up: |