handsontable / hyperformula

HyperFormula is an open-source headless spreadsheet for business web apps. It comes with over 400 formulas, CRUD operations, undo-redo, clipboard support, and sorting.
https://hyperformula.handsontable.com/
GNU General Public License v3.0
1.88k stars 107 forks source link

Add generic context option for custom function resolution #1398

Closed michaelbridge closed 3 months ago

michaelbridge commented 3 months ago

Context

Enable pass-through of generic parameters to underlying custom functions via context option. Further discussion here.

How did you test your changes?

Added tests; ran npm run test

Types of changes

Related issues:

  1. Fixes #808

Checklist:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.36%. Comparing base (48bceb0) to head (0d30593).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/handsontable/hyperformula/pull/1398/graphs/tree.svg?width=650&height=150&src=pr&token=5k9ZQv8azO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=handsontable)](https://app.codecov.io/gh/handsontable/hyperformula/pull/1398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=handsontable) ```diff @@ Coverage Diff @@ ## develop #1398 +/- ## ======================================== Coverage 97.36% 97.36% ======================================== Files 169 169 Lines 14421 14422 +1 Branches 3100 3100 ======================================== + Hits 14041 14042 +1 Misses 377 377 Partials 3 3 ``` | [Files](https://app.codecov.io/gh/handsontable/hyperformula/pull/1398?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=handsontable) | Coverage Δ | | |---|---|---| | [src/Config.ts](https://app.codecov.io/gh/handsontable/hyperformula/pull/1398?src=pr&el=tree&filepath=src%2FConfig.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=handsontable#diff-c3JjL0NvbmZpZy50cw==) | `98.01% <100.00%> (+0.01%)` | :arrow_up: |
sequba commented 3 months ago

Merging to temporary branch feature/issue-1396 to resolve conflicts with develop