Updated breaking changes to Handsontable 0.34+ as mentioned issue #219

[churchs19]

Updated breaking changes to Handsontable 0.34+ as mentioned in https://github.com/handsontable/ngHandsontable/issues/219#issuecomment-334266247.

Removed irrelevant tests due to Copy/Paste refactoring in Handsontable 0.33+

[veneliniliev]

please merge this pull request!

[kangzheTW]

@AMBudnik Do you have the plan to update the underlying handsontable to a version newer than 0.28?

[AMBudnik]

Sorry but I do not have any news on ngHandsontable. We are switched our resources to update the Angular 2+ wrapper

[vkirienko]

Hi,

How come you just bumped version with two changes to support v8 when this is broken for more that two years? And btw line 33 should be fixed as following:

var row = this.instance.getSelectedLast()[0];

[AMBudnik]

Hi @vkirienko that issue was out of the scope for that operation.

[vkirienko]

I get that but it does not make sense to add support for latest Handsontable version and have code that is clearly broken in that very same version for already two years. Please make up your mind. You don't support this repo then don't make any changes to it. Or you do support it, then please fix obvious bugs that were reported two years ago (with fixes already provided). You can't be sitting on two chairs at the same time. On Sep 9, 2020 7:33 AM, Aleksandra Budnik notifications@github.com wrote: Hi @vkirienko that issue was out of the scope for that operation.

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

[AMBudnik]

Hi @vkirienko we made that update to support a crucial project. Its requirements are basic but as we've made a lot of beneficial changes in v8.0.0 of Handsontable we wanted to use them. We do not force anyone to update and we always encouraged to fork the project by keeping this repository under MIT license.