handsontable / ngHandsontable

Official AngularJS directive for Handsontable
http://handsontable.github.io/ngHandsontable/
MIT License
433 stars 159 forks source link

Issue with updateSettings - Handsontable + AngularJS. #237

Closed Raphael007123 closed 6 years ago

Raphael007123 commented 6 years ago

@AMBudnik An issue with updateSettings on updating the mergeCells. And also header is not get fixed it gives conflicts with the page header. I have updated the code in plunker http://plnkr.co/edit/wFyBiwxRN9En0VdgHeMj?preview

step1: click on any cell. step 2: click on edit button expected result : new row with merged cells (and a form inside the cell)

result: error (console): handsontable.min.js:29 The merged cell declared at [, ] overlaps with the other declared merged cell. The overlapping merged cell was not added to the table, please fix your setup.

Thanks in advance.

AMBudnik commented 6 years ago

Is that the final demo @Raphael007123 ?

When I open it it looks like this

gif

and I get different logs

 Uncaught TypeError: (t.data || "").search is not a function
    at pmh (sh.bb33dde1e68b50ad374644e5.html:1)
angular.js:13424 TypeError: Cannot read property 'length' of undefined
    at handsontable.min.js:29
    at u (handsontable.min.js:29)
    at t.value (handsontable.min.js:29)
    at t.value (handsontable.min.js:29)
    at t.value (handsontable.min.js:29)
    at t.value (handsontable.min.js:29)
    at t.value (handsontable.min.js:29)
    at i.<anonymous> (handsontable.min.js:29)
    at e.value (handsontable.min.js:29)
    at i.runHooks (handsontable.min.js:29)
(anonymous) @ angular.js:13424
angular.js:13424 TypeError: Cannot read property 'offsetLeft' of undefined
    at b (handsontable.min.js:29)
    at e.value (handsontable.min.js:29)
    at e.value (handsontable.min.js:29)
    at e.value (handsontable.min.js:29)
    at e.value (handsontable.min.js:29)
    at e.value (handsontable.min.js:29)
    at r.render (handsontable.min.js:29)
    at i._refreshBorders (handsontable.min.js:29)
    at i.render (handsontable.min.js:29)
    at Object.renderHandsontable (ngHandsontable.js:164)
(anonymous) @ angular.js:13424
24handsontable.min.js:29 Uncaught TypeError: Cannot read property 'offsetLeft' of undefined
    at b (handsontable.min.js:29)
    at e.value (handsontable.min.js:29)
    at e.value (handsontable.min.js:29)
    at e.value (handsontable.min.js:29)
    at e.value (handsontable.min.js:29)
    at e.value (handsontable.min.js:29)
    at e.value (handsontable.min.js:29)
    at e.value (handsontable.min.js:29)
    at e.value (handsontable.min.js:29)
    at handsontable.min.js:29
 Uncaught TypeError: (t.data || "").search is not a function
    at pmh (sh.bb33dde1e68b50ad374644e5.html:1)
Raphael007123 commented 6 years ago

@AMBudnik new

Im getting error like this. but when i comment the updateSettings function error will get vanished

$scope.data.updateSettings({ mergeCells: $scope.rowToMerge, });

AMBudnik commented 6 years ago

It looks like the $scope.rowToMerge returns

image

while the mergeCells also requires (besides row and col) the rowspan and colspan https://docs.handsontable.com/pro/2.0.0/demo-merged-cells.html

If I do not add these parameters I will get the log http://jsfiddle.net/dktva355/

Please Try to add them and check if the issue still occur.

Raphael007123 commented 6 years ago

@AMBudnik thanks for the update

Also as i noted above there is another issue, That's header is not get fixed it gives conflicts with the page header. when we scroll down table header goes up and make conflicts with the page header

http://plnkr.co/edit/wFyBiwxRN9En0VdgHeMj?preview

page