handsontable / vue-handsontable-official

Vue Data Grid with Spreadsheet Look & Feel. Official Vue wrapper for Handsontable.
https://handsontable.com/docs/vue
MIT License
746 stars 128 forks source link

If a key is set on a custom editor component, include it in the editorCache key #178

Closed jasonlfunk closed 4 years ago

jasonlfunk commented 4 years ago

Context

With the merging of #173, it's now possible to pass props to custom editors. However, in my use case, I wanted to use the same editor component but pass different props for the different columns. However, since the editor cache was caching by the component's name only, it would only use the first column's editor.

How has this been tested?

I've added a test which mounts the same editor twice with two different keys and ensured that the props are different.

Types of changes

Related issue(s):

  1. 173

Checklist:

codesandbox-ci[bot] commented 4 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0c62dcd3a08b1b62e8f3169a494a460ccd96d2cf:

Sandbox Source
handsontable/examples: pull-request Configuration
pnowak commented 4 years ago

Hi @jasonlfunk

Thank you for your effort and work.

Can you sign this Contributor License Agreement -https://docs.google.com/forms/d/e/1FAIpQLScpMq4swMelvw3-onxC8Jl29m0fVp5hpf7d1yQVklqVjGjWGA/viewform?c=0&w=1&usp=send_form - to allow us to publish your changes to the code?

This is the first of our contributing rules - https://github.com/handsontable/handsontable/blob/master/CONTRIBUTING.md

jasonlfunk commented 4 years ago

Hi @jasonlfunk

Thank you for your effort and work.

Can you sign this Contributor License Agreement -https://docs.google.com/forms/d/e/1FAIpQLScpMq4swMelvw3-onxC8Jl29m0fVp5hpf7d1yQVklqVjGjWGA/viewform?c=0&w=1&usp=send_form - to allow us to publish your changes to the code?

This is the first of our contributing rules - https://github.com/handsontable/handsontable/blob/master/CONTRIBUTING.md

Done.

pnowak commented 4 years ago

Thank you @jasonlfunk

aninde commented 4 years ago

We need additional tests for this new feature and information in the docs.

AMBudnik commented 4 years ago

Hi @jasonlfunk

I'm happy to announce that this change has been published under v 5.1.0. Thank you for your collaboration.