handsontable / vue-handsontable-official

Vue Data Grid with Spreadsheet Look & Feel. Official Vue wrapper for Handsontable.
https://handsontable.com/docs/vue
MIT License
746 stars 128 forks source link

Pre-8.0.0 adjustments #180

Closed jansiegel closed 4 years ago

jansiegel commented 4 years ago

Context

How has this been tested?

Tested manually and by running the test cases.

Types of changes

codesandbox-ci[bot] commented 4 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 54c5fbec1d3956a2e9e8976f4434a6396aa44a77:

Sandbox Source
handsontable/examples: pull-request Configuration
aninde commented 4 years ago

The demo doesn't work https://github.com/handsontable/vue-handsontable-official/pull/180#issuecomment-660971801. I can't test.

Screenshot 2020-07-21 at 11 08 30
jansiegel commented 4 years ago

@aninde

The demo doesn't work #180 (comment). I can't test.

It looks like an issue with codesandbox, so you can try to test it locally.

jansiegel commented 4 years ago

https://github.com/handsontable/vue-handsontable-official/pull/180/commits/1994375a35e23b8a3cebe7cf8c74b124a71baf51 contains changes for handsontable/handsontable#7145, so it needs to be tested with the current Handsontable develop (https://github.com/handsontable/handsontable/commit/aa00b372c757653e98a762bc8a7d76c2d3e19344 +).

aninde commented 4 years ago

Demo built as @jansiegel requested https://jsfiddle.net/aninde/30u6t2fw/ Here Vanilla Handsontable from the same build. https://jsfiddle.net/aninde/vyks3x6h/ without this regression.

Regression bug 1 After Insert operations orRemove columns undo doesn't work, there is no such option at all in the context menu. Undo work after removing rows from the contextMenu, but not after removing colums.

undo-ff

Regression bug 2 Wrong data are displaying after undoing removal of rows https://jsfiddle.net/aninde/b5fkyLaq/. Kapture 2020-07-23 at 16 09 01

jansiegel commented 4 years ago

Regression bug

Not really a regression (as it happens in the current version as well: https://jsfiddle.net/js_ziggle/ejabsc37/1/), but a bug for sure. @aninde could you report a new issue for the problem?

aninde commented 4 years ago

@aninde could you report a new issue for the problem?

Of course.

Regression 2 it also occurred before, but in a different form. In my opinion, with the v8 is worse. https://jsfiddle.net/aninde/wyz67Lnd/ v.7.4.2 for comparing to https://jsfiddle.net/aninde/b5fkyLaq/. stable-reg2

aninde commented 4 years ago

Regression 3 Indexes are lost. While I'm Inserting on moved row, insert works on the wrong row. It's regression comparing to stable Vanilla and 7.4.2 with Vue-Handsontable. The same bug is present after inserting col on moved column https://jsfiddle.net/aninde/u6y1c59z/

v8 https://jsfiddle.net/aninde/9azqx2jw/ v8 v7 https://jsfiddle.net/aninde/45Lps81t/ v7

v8, insert on moved column moved-col

aninde commented 4 years ago

Regression 4 Doubled border on bottom edge of colHeader https://jsfiddle.net/aninde/h29nocb0/ - this, currently tested version. https://jsfiddle.net/aninde/0khw4dgj/ - v.7.4.2 - fixed, vanilla from the same build of Handsontable https://jsfiddle.net/aninde/cob8zv96/ develop fixed.

jansiegel commented 4 years ago

@aninde

Regression 4 Doubled border on bottom edge of colHeader https://jsfiddle.net/aninde/h29nocb0/ - this, currently tested version.

vanilla from the same build of Handsontable https://jsfiddle.net/aninde/cob8zv96/ develop fixed.

I can see the same wider border in both of these demos, which would indicate it's a not a wrapper issue.

jansiegel commented 4 years ago

@wojciechczerniak I merged the logic from #185 here, because it turned out to need handsontable@8.0.0-beta.2+ to work properly anyway.