search

hanenehrizi / sipdroid

Automatically exported from code.google.com/p/sipdroid
GNU General Public License v3.0
0 stars 0 forks source link

Workaround for Gizmo5 instant call drop #230

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
///////////////////////////////////////////////////////////
// This software is compiled for peasonal use, but in case 
// you need it, feel free to download and use it.
// For APK file installation guide, please visit http://is.gd/5lb6C
// All credits go to The Sipdroid Open Source Project.
//////////////////////////////////////////////////////////

This software is edited & compiled based on the Sipdroid version 1.2.1, I
added an option for users to TURN OFF the voice compression feature, to
avoid the instant call drop issue with Gizmo5 service.

With language fix in English, German, French, Italian, simplified and
traditional Chinese. Other locales should display in English.

And please be notified, I could swear I did not put anything harmful in it,
but sadly that can't be proven. So please think twice before you download it.

Original issue reported on code.google.com by nio....@gmail.com on 12 Dec 2009 at 7:05

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by pmerl...@googlemail.com on 12 Dec 2009 at 9:55

GoogleCodeExporter commented 8 years ago 
Check in your change into the source, please.

Original comment by pmerl...@googlemail.com on 12 Dec 2009 at 10:06

GoogleCodeExporter commented 8 years ago 
Changes commited. I don't know how things work with this project, sorry for the
inconvenience.

Original comment by nio....@gmail.com on 13 Dec 2009 at 12:10

GoogleCodeExporter commented 8 years ago

Original comment by pmerl...@googlemail.com on 13 Dec 2009 at 2:41

GoogleCodeExporter commented 8 years ago 
Hi developers,

I've made another fix to Sipdroid (r385) so that it can determine a audio codec
dynamically base on capacity negotiation by SDP offer and answer.

In this version, Sipdroid fall-backs to G.711 when your sip provider does not 
support
GSM codec.

Please consider to merge this patch. 
It also include implementation of G.711 u-law.

Thanks.

Original comment by tm.in...@gmail.com on 13 Dec 2009 at 4:18

Attachments:

GoogleCodeExporter commented 8 years ago 
Yes, looks good to me. I've added you as a member.

Could you please include some comments:

1) @@ -472,10 +550,32 @@

        changeStatus(UA_STATE_INCOMING_CALL,caller.toString());

-       initSessionDescriptor();
        if (sdp != null) { 

Why did you remove initSessionDescriptor for the case where sdp==null?

2) -            new_sdp = SdpTools.sdpAttirbuteSelection(new_sdp, "rtpmap");
+           //new_sdp = SdpTools.sdpAttirbuteSelection(new_sdp, 
"rtpmap"); ////change multi codecs

Why did you comment out this line?

3) +        //change end
+
        if (user_profile.no_offer) {
-           // Create the new SDP

Why did you move out all the lines from the no_offer case?

Original comment by pmerl...@googlemail.com on 13 Dec 2009 at 10:07

GoogleCodeExporter commented 8 years ago 
Please don't check your patch in yet.

Reason is based on the user option for preferred codec the code should select 
one. If 
the server just offers GSM this should always work if preferred codec is 
different.

Do you think you can streamline the code such that the option evaluation (with 
setting 
and evaluating UseGSM) will only be contained once?

Original comment by pmerl...@googlemail.com on 14 Dec 2009 at 1:32

GoogleCodeExporter commented 8 years ago 
Thanks for your review.

> 1) Why did you remove initSessionDescriptor for the case where sdp==null?
> 3) Why did you move out all the lines from the no_offer case?

Actually, no_offer case was not well-considered in my code. I've corrected the 
code 
and send a patch again.

> 2) Why did you comment out this line?

sdpAttirbuteSelection("rtpmap") remains only one rtpmap attribute, but it's not 
adequent if multiple codecs were selected.

> Do you think you can streamline the code such that the option evaluation 
(with 
setting and evaluating UseGSM) will only be contained once?

The basic behavior of GSM usage is not changed from 1.2.1 by my patch.
I think we need discussion about what is user's preference about compressed 
audio.

Original comment by tm.in...@gmail.com on 14 Dec 2009 at 1:49

Attachments:

GoogleCodeExporter commented 8 years ago 
The code is much clearer now. Please check it in. I'll do some tests with PBXes 
before 
releasing it.

Original comment by pmerl...@googlemail.com on 14 Dec 2009 at 4:05

GoogleCodeExporter commented 8 years ago

Original comment by pmerl...@googlemail.com on 14 Dec 2009 at 8:53