Preserve html nodes as text

hanford / remark-slate

Remark plugin to compile Markdown as a slate 0.50+ compatible object.

155 stars 42 forks source link

Preserve html nodes as text #32

Closed Andarist closed 3 years ago

Andarist commented 3 years ago

I think this as a default makes more sense - we had to dig into why the whole particular input string has vanished completely and why it couldn't be rendered.

It seems to me that any transformations on html should be pluggable as in some cases it might actually be required for this part to be preserved. I haven't thought about this problem space long enough though - would first need to figure out what kind of HTML could/should be normalized to Slate nodes.

hanford commented 3 years ago

I think this is fine, I'll merge/cut a release tomorrow!

Andarist commented 3 years ago

Cool, thank you! I have updated the tests so the CI should get ✅ now

EDIT:// well, CI is failing but not because of this change 😉

hanford commented 3 years ago

Thanks @Andarist, this change is live in v1.6.0!