search

hangforever / hangzone-frontend

An app that enables hangers all over the world to discover and share zones in which to hang ;)
GNU Affero General Public License v3.0
1 stars 0 forks source link

Feature/make zone #33

Closed scootyboots closed 4 years ago

scootyboots commented 4 years ago

The goal is to make it so when someone goes to make a new zone then they're prompted with some kind of modal to get through the process.

Right now it's just logic to toggle for the modal.

scootyboots commented 4 years ago

@aburd lemme know what you think. I think this is ready for review.

aburd commented 4 years ago

Code doesn't seem bad at all, but the styling makes the modal look weird based on screen height.

スクリーンショット 2020-08-07 1 57 23 スクリーンショット 2020-08-07 1 57 29

scootyboots commented 4 years ago

@aburd I've fixed the content overflow issue and added some more styling.

scootyboots commented 4 years ago

hey @aburd

I pulled from master and resolved the conflicts - not sure what I made this branch from to be honest hehe woops.

I made the chances to toggleActive you suggested. Also decided to add a public check box and make only one of the two selectable at a time.

Also removed the fixed height on the modal because it was looking pretty poopy with a small number of elements inside.

Do you wanna give it another look or should I go ahead and merge?