hanggrian / socialview

Android TextView and EditText with hashtag, mention, and hyperlink support
http://hanggrian.com/socialview/
Apache License 2.0
331 stars 81 forks source link

Mentions with different languages #13

Closed vivchik1337 closed 7 years ago

vivchik1337 commented 7 years ago

Hello, my friend. Thanks for your work. I have some problems, with mentions on other languages. For example I need to click on @Андрей mention, but on text view it looks like simple text, so I cant click on it. Can you fix it?

hanggrian commented 7 years ago

I suppose I could, if only I'm familiar with Russian name customs. I kind of need your help for this one, can you round up all Russian characters (like н, д, й), and some Russian common names for test cases?

vivchik1337 commented 7 years ago

Hi, here all characters of russian and names Name: Андрей, Владимир, Дмитрий, Вова, Саша Upper case: АБВГДЕЁЖЗИЙКЛМНОПРСТУФХЦЧШЩЪЫЬЭЮЯ

Lower case: абвгдеёжзийклмнопрстуфхцчшщъыьэюя

14 июля 2017 г. 2:36 пользователь "Hendra Anggrian" < notifications@github.com> написал:

I suppose I could, if only I'm familiar with Russian name customs. I kind of need your help for this one, can you round up all Russian characters (like н, д, й), and some Russian common names just for test cases?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HendraAnggrian/socialview/issues/13#issuecomment-315230039, or mute the thread https://github.com/notifications/unsubscribe-auth/ANB5GzgAioe4mWsIe0ghDYb7giqu06jzks5sNqnrgaJpZM4OW_v- .

hanggrian commented 7 years ago

Noted, I'll work on it and I'll post you back within days.

hanggrian commented 7 years ago

@sfucko Hi there, can you do me a favor again? Would you mind pull the latest code and try it with as many Russian sentences as you could. I have updated the regex to accept more characters and it's working quite well in my test case, but I really need more tests before I push the update.

vivchik1337 commented 7 years ago

Sorry, I can`t pull( can you update and then if there are some troubles here you will revert changes, please

hanggrian commented 7 years ago

@sfucko to make it easier I've pushed example apk. Can you please try it and let me know if it works with Russian characters?

vivchik1337 commented 7 years ago

yes, of course my friend:)

18 июля 2017 г. 12:06 пользователь "Hendra Anggrian" < notifications@github.com> написал:

@sfucko https://github.com/sfucko to make it easier I've pushed example apk https://github.com/HendraAnggrian/socialview/raw/master/example/example-debug-0.1.apk. Can you please try it and let me know if it works with Russian characters?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HendraAnggrian/socialview/issues/13#issuecomment-316003894, or mute the thread https://github.com/notifications/unsubscribe-auth/ANB5G4QcJAPK021ZirIJnZmuKh2MOcqYks5sPHWJgaJpZM4OW_v- .

vivchik1337 commented 7 years ago

I`ve tested it, it works well. You can update version:) Thank you

vivchik1337 commented 7 years ago

Can you update faster. I have deadline, so I need to do it for tommorow. Please

hanggrian commented 7 years ago

In a road, will do it once I get home.

hanggrian commented 7 years ago

@sfucko version 0.15.1 is out with this regex, thanks for your help!