Closed stanbar closed 6 years ago
and you forgot to set the visibility if the hashtag.count is not null
This is an interesting topic. When a count is not null and 0, should count view also be gone?
Yes, I would like to show 0 count as well
hashtag.count
null checks combined, and merged. Thanks for your contribution!
Hello my friend. The same thing happens in MentionArrayAdapter
You set the text
if (!mention.displayname.isNullOrEmpty()) {
holder.displaynameView.text = mention.displayname
}
but doesn't change visibility, which is always
<TextView
android:id="@+id/socialview_mention_displayname"
style="?android:attr/dropDownItemStyle"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:ellipsize="marquee"
android:singleLine="true"
android:textAppearance="?textAppearanceLargePopupMenu"
android:visibility="gone" />
gone
I will investigate this, but I warn you, it could take some time. This library is undergoing downgrade to Java.
Why is that ? :O
I began to question that myself. But I'm supposed it's for lower dependencies since not everyone uses Kotlin. And this is a fairly simple project, Kotlin might have been an overkill.
getQuantityString require twice if you want formating From docs
and you forgot to set the visibility if the
hashtag.count
is not null