search

hangnoh / flybaseR

2 stars 2 forks source link

setdiff(x, result) in line 188 of id.converter.R #3

Open rmd13 opened 5 years ago

rmd13 commented 5 years ago

in line 188 of id.converter.R

message(paste("Total # of ID mismatches : ", length(setdiff(x, result)), " (will show no match if ID -> symbol or gene -> protein conversion)" , sep=""))

For setdiff(x, result), the x was the input, and result is the output. They are different presentations, so the setdiff is unclear here, right?

hangnoh commented 5 years ago

Oh, thanks for pointing it out! Yes, it is less clear. My original intention, which I should guess now (LOL!), was that to provide Flybase gene IDs that have been updated. Flybase gene IDs are continuously being updated, although people there are trying to minimize such changes. Let me rewrite the script later to make the point clearer.

rmd13 commented 5 years ago

So that means if to provide Flybase gene IDs that changed, the input argument should also be IDs, not the genes symbols, or mutations...