haniceboy / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

Gyp files as source creates issue when not in directory for generated project files. #225

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Run 'python gyp_skia' on Windows in order to create Visual Studio projects 
for skia with gyp r1057.

What is the expected output? What do you see instead?
A clean generation of projects. Instead for every gyp file there is an error of 
the form

Warning: Missing input file ..\..\gyp\xps.gyp

What version of the product are you using? On what operating system?
gyp r1057 with Windows7 generating for both VS2008 and 2010.

Please provide any additional information below.
Attached is a patch to fix this issue while leaving everything else alone. Skia 
puts .gyp files in ./gyp and outputs the VS project files to ./out/gyp. The 
issue is that the initial list of sources is relative to the gyp file, but the 
gyp file is added to this list relative to the project files instead.

Original issue reported on code.google.com by bunge...@google.com on 30 Sep 2011 at 4:14

Attachments:

GoogleCodeExporter commented 9 years ago
Review at http://codereview.appspot.com/5167047/

Original comment by bunge...@google.com on 30 Sep 2011 at 9:15

GoogleCodeExporter commented 9 years ago

Original comment by bunge...@chromium.org on 3 Oct 2011 at 5:50