type 'executable' target depending on type 'none' target depending on type 'static_library' target brings that library into the executable's link

haniceboy / gyp

Automatically exported from code.google.com/p/gyp

0 stars 0 forks source link

type 'executable' target depending on type 'none' target depending on type 'static_library' target brings that library into the executable's link #239

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

Seen in 
http://src.chromium.org/viewvc/native_client/trunk/src/native_client/src/trusted
/service_runtime/service_runtime.gyp?revision=7277&view=markup when 
nacl_helper_bootstrap dependency is uncommented.

This can also be observed in the chromium build on Linux (as of r111437, might 
change later) where libnacl_helper_bootstrap_lib.a is included in the link of 
chrome.  In that case it happens to be harmless, whereas it is harmful for the 
link of sel_ldr in the native_client tree.

Original issue reported on code.google.com by mcgra...@chromium.org on 24 Nov 2011 at 12:20

GoogleCodeExporter commented 9 years ago

Original comment by bradnelson@google.com on 24 Nov 2011 at 12:23

Changed state: Accepted
Added labels: Priority-High
Removed labels: Priority-Medium

GoogleCodeExporter commented 9 years ago

Commit: 4f8e92ca01139033a0f93b12b5ae44ec482463a6
 Email: bradnelson@google.com@78cadc50-ecff-11dd-a971-7dbc132099af

Preventing dependency on a static library from traversing a none target, unless 
the none target is marked with 'dependencies_traverse': 1,

TEST=coming soon, want to make sure approach is ok.
BUG=http://code.google.com/p/gyp/issues/detail?id=239
R=mark@chromium.org,mcgrathr@chromium.org
Review URL: http://codereview.chromium.org/8981011

git-svn-id: http://gyp.googlecode.com/svn/trunk@1108 
78cadc50-ecff-11dd-a971-7dbc132099af

M   pylib/gyp/input.py
M   test/dependencies/b/b.gyp
A   test/dependencies/b/b3.c
A   test/dependencies/gyptest-none-traversal.py
A   test/dependencies/main.c
A   test/dependencies/none_traversal.gyp

Original comment by bugdro...@chromium.org on 19 Dec 2011 at 7:24

GoogleCodeExporter commented 9 years ago

This issue doesn't record the fact that the sense of the flag got inverted.
I think it can reasonably be closed now.  Though it's sensible enough to use 
this bug tag to record further changes like replacing 
type=none/dependencies_traverse=0 with type=custom or a similarly 
comprehensible version of this feature.

Original comment by mcgra...@chromium.org on 18 Jan 2012 at 12:40