Open BioinfoTongLI opened 1 year ago
Attention: 9 lines
in your changes are missing coverage. Please review.
Comparison is base (
c34922d
) 36.28% compared to head (0fcf094
) 36.27%. Report is 25 commits behind head on dev.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is not how dynamic process allocation is supposed to be used:
cpus = { 1 * task.attempt * task.attempt}
memory = { 10.GB * task.attempt * task.attempt}
That would force process to effectively fail at least one to get the right number of resources for the 4/20G profiles. Moreover, it also hides the number of cpus/mem that's required by each process by using task.attempt**2
I highly advice having labeled processes (not named) to be able to provide generic groups of resources like this:
process {
withLabel: small {
cpus = 1
memory = 4.GB
}
withLabel: large {
cpus = 4
memory = 20.GB
}
}
...and then go back to the processes and add the right labels.
Should you want to make those 'dynamic' too you could do something like:
process {
withLabel: small {
cpus = 1
memory = { 4.GB * task.attempt }
}
withLabel: large {
cpus = 4
memory = { 20.GB * task.attempt }
}
}
… default parameters