hanigamal / phpliteadmin

Automatically exported from code.google.com/p/phpliteadmin
0 stars 0 forks source link

edit/delete multiple rows in search mode #216

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
When i click a table name, i get nice results with checkbox (to edit/del few or 
all) and single edit/del.

when i search (Tab: SEARCH), my results are without checkbox, only single 
edit/del

and when i use sql statment (Tab: SQL), there are none of these options. i only 
can see my results but cant edit/del

Any reason for this or we still didnt add these options?

Original issue reported on code.google.com by teryaki1...@googlemail.com on 17 May 2013 at 12:06

GoogleCodeExporter commented 9 years ago
When you do an SQL statement, there is a reason why you don't have edit/delete 
buttons: What you see might not be a real table, it might be joined across 
multiple tables, aggregated, grouped data or stuff like this. It is impossible 
to edit such data.
Example query: SELECT AVG(e.salary) sal, d.department FROM employee e, 
department d WHERE d.department = e.department GROUP BY e.department

You have 2 source tables in here, grouped data and aggregation on these groups. 
What should happen to the source data if you edit the AVG column?

That said, for the search tab this argument does not really hold. There, you 
always see data from only one table and there is no grouping or aggregation 
done, only filtering.
Having checkboxes there should be possible.

If we do this, we should have a look at the code. I think there is redundant 
code around this.

Original comment by crazy4ch...@gmail.com on 17 May 2013 at 12:46

GoogleCodeExporter commented 9 years ago
For the reasons above, I reject the request to add edit/delete to SQL-tab 
results.

Therefore, the remaining issue is to add checkboxes in the search-results to be 
able to delete/edit multiple rows. I accept this request and change the issue 
title accordingly.

Original comment by crazy4ch...@gmail.com on 17 May 2013 at 12:50

GoogleCodeExporter commented 9 years ago
Yep, you right, thx for the statement example

Adding checkbox for search results is enough.

Original comment by teryaki1...@googlemail.com on 17 May 2013 at 1:06

GoogleCodeExporter commented 9 years ago

Original comment by dj.nan...@gmail.com on 23 Oct 2013 at 1:22

Attachments:

GoogleCodeExporter commented 9 years ago
I guess you posted the gmail icon by mistake? :D

Original comment by crazy4ch...@gmail.com on 23 Oct 2013 at 2:17