hanjcat / teacozy

Codecademy Teacozy Project
0 stars 0 forks source link

Values of 0 in CSS don't need units #2

Open griffinlacek opened 7 years ago

griffinlacek commented 7 years ago

Generally in CSS you don't add units to values of 0 since it doesn't matter what unit it is (either way it's 0). There's a few spots they're included. It's not a big deal if values of zero have units attached, but it's always good to be as consistent as possible!

https://github.com/hanjcat/teacozy/blob/master/Resources/CSS/style.css#L11 https://github.com/hanjcat/teacozy/blob/master/Resources/CSS/style.css#L30 https://github.com/hanjcat/teacozy/blob/master/Resources/CSS/style.css#L48-L49 https://github.com/hanjcat/teacozy/blob/master/Resources/CSS/style.css#L91-L92 https://github.com/hanjcat/teacozy/blob/master/Resources/CSS/style.css#L138

hanjcat commented 6 years ago

Oh, I see. Alright, I'll remember that from now on. Thanks!