search

hanjoongcho / aaf-easydiary

:blue_book: A diary application optimized for user experience.
GNU General Public License v3.0
440 stars 123 forks source link

F-Droid can't build #212

Open licaon-kter opened 1 year ago

licaon-kter commented 1 year ago

ref: https://monitor.f-droid.org/builds/log/me.blog.korn123.easydiary/294#site-footer

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/718e73069a37a140ad6673d507567490743068a2

licaon-kter commented 1 year ago

Still failing: https://monitor.f-droid.org/builds/log/me.blog.korn123.easydiary/295#site-footer

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/cb20ec4a96d541496d6f8353016fafc3153d9105

hanjoongcho commented 1 year ago

Hi~ @licaon-kter It was processed as follows.

licaon-kter commented 1 year ago

The thing is that you publish -fdroid suffixed tags... but F-Droid is not instructed to use those: https://gitlab.com/fdroid/fdroiddata/-/blob/cbd6a01d28edf89942921a31c87922b674eb2e92/metadata/me.blog.korn123.easydiary.yml#L839

Buuut.. funny enough even the non-fdroid tagged release appear to build fine: https://f-droid.org/packages/me.blog.korn123.easydiary/

There was a change of plans?

hanjoongcho commented 1 year ago

@licaon-kter The googleplay version and f-droid version system are exactly the same. Only the build options are different. (In the case of f-droid build, the function using the gms library is disabled.) The reason f-droid suffix was added last time is that the distribution of f-droid is dependent on tagging, so suffix is attached to mean that only f-droid is distributed without distribution of the google play version.

v1.4.295.202304180: googleplay & f-droid distribution v1.4.296.202304210-fdroid: f-droid distribution v1.4.297.202304260: googleplay & f-droid distribution

licaon-kter commented 1 year ago

I did not understand, but if it works, mmmkay,

licaon-kter commented 9 months ago

and again: https://gitlab.com/fdroid/fdroiddata/-/jobs/6244150408#L1045

ref: https://github.com/hanjoongcho/aaf-easydiary/blob/v1.4.305.202402230/app/src/main/java/me/blog/korn123/easydiary/helper/BaseAlarmWorkExecutor.kt#L4-L10 these need to be moved to gms

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/c55232aea2269252809ca05a2824b7730e977041