search

hankangbok / stardroid

Automatically exported from code.google.com/p/stardroid
0 stars 0 forks source link

Enhancement request: Fixing horizon during manual-mode time travel #9

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
(This is my first post to code.google - please let me know if there is a better 
place to talk about these)

During time-travel in manual-mode, it is useful to fix the horizon and let the 
stars (and others) move in the background. This gives me an idea of what to 
expect(over time)in a certain section of the sky from where I am currently 
stationed.

I have made a very small change - locally - to AstronomerModelImpl for this 
feature and is working neatly. Also added a toggle for this feature in the 
menus.

P.S: I have a few other such code changes and enhancement requests - but I am 
not sure what the exact process is for getting these changes reviewed and 
submitting them. Could the project owners or someone else provide some 
direction?

Thanks!

Original issue reported on code.google.com by conrad.h...@gmail.com on 1 Feb 2012 at 4:29

GoogleCodeExporter commented 8 years ago 
I want to clarify that, though the same objective can be achieved by using auto 
mode and then pointing the device to the required section of the horizon, the 
comfort of the manual mode is worth this "redundancy".

Original comment by conrad.h...@gmail.com on 1 Feb 2012 at 4:40

GoogleCodeExporter commented 8 years ago 
Sorry for the slow response. I was away for a couple of days.

I'm not sure of the right way to submit change requests... this is my first 
time managing an open source project. :-)

I think the process will be for you to explain the new feature/bug fix, and 
then if we accept it, send us a change list to review. There is a "Request Code 
Review" item in the Source menu. I *think* that's what we're going to do, but I 
need to verify. I will do that in the morning and get back to you.

Original comment by kevin.se...@gmail.com on 6 Feb 2012 at 2:01

GoogleCodeExporter commented 8 years ago 
Conrad,

Can you send me a short description of your changes? If we decide to go with 
them, then we'll do a quick code review before we submit them. Note that we are 
pretty likely to accept them unless they are contrary to our plans for the app.

Send the descriptions to either my email address (kevin.serafini@gmail.com) or 
to the Sky Map Google group (google-sky-map@googlegroups.com). Its much easier 
doing this through email.

Thanks,
Kevin

Original comment by kevin.se...@gmail.com on 6 Feb 2012 at 10:34