hankhank10 / vinylemulator

Emulate the tactile experience of a vinyl collection through your Sonos system, but with a back end run by Spotify
https://www.hackster.io/mark-hank/sonos-spotify-vinyl-emulator-3be63d
GNU General Public License v3.0
169 stars 28 forks source link

Support for writing tags #2

Open lukatmyshu opened 4 years ago

lukatmyshu commented 4 years ago

Wanted to be able to write tags in a similar fashion without having to SSH into the pi or move the NFC reader to a laptop.

What this PR does is use the currently playing song from Sonos to determine what the album to write is - so if you tap a tag w/ no NFC records on it it will

I wouldn't merge it in it's current form since it adds a few dependencies and only works for Spotify - if there's interest I can clean it up to make it a bit easier to merge.

PR also includes code for pausing the player when you remove the tag from the reader (further emulating a vinyl player)

hankhank10 commented 4 years ago

Thank you for doing this. I think it would be a great addition to the project and would like to merge it in.

Could I suggest that instead of incorporating this into readnfc.py (which often runs in the background) you instead add your code as writenfc.py? I would then be keep to merge this into the master.

Thanks! This is a great feature!

hankhank10 commented 4 years ago

Could I also ask that you add a short section into the readme.md explaining how this works?

Thanks!

lukatmyshu commented 4 years ago

I have a separate utility that’s a command line interact that does that.

The thing about the way I built it is that it still works in the background.

You play a album on Sonos (using the normal app). You then put an empty NFC card on the reader - the code detects there isnt a record there and then pulls the URI automatically. Does that make sense?

Happy to add the changes to the README. I’m also gonna see if it can determine custom playlists.

Vijay

On Fri, Jul 3, 2020 at 11:49 AM hankhank10 notifications@github.com wrote:

Thank you for doing this. I think it would be a great addition to the project and would like to merge it in.

Could I suggest that instead of incorporating this into readnfc.py (which often runs in the background) you instead add your code as writenfc.py? I would then be keep to merge this into the master.

Thanks! This is a great feature!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hankhank10/vinylemulator/pull/2#issuecomment-653648041, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABCXQIGQHIW62LTP3Z4RILRZYR4LANCNFSM4OP7ADFQ .

leviathanprojects commented 3 years ago

Is there any chance of this getting merged into the master? Really keen to use the pause feature + blank tag writing.

hankhank10 commented 3 years ago

I would be happy to merge this into the master once it is tidied and tested

@lukatmyshu let me know if you're still keen to tidy this up and get it included

phranck commented 2 years ago

Any news on this topic, @lukatmyshu?