search

hankinsoft / SQLPro

SQLPro bug & features tracking.
100 stars 27 forks source link

CSV Import UI becomes unresponsive after mapping changes #907

Closed gabriel-r closed 1 year ago

gabriel-r commented 1 year ago

Describe the bug While importing a CSV as a new table, setting a column as <SKIP> grays out the other columns and doesn't allow reverting to a valid column title.

To Reproduce Steps to reproduce the behavior:

  1. With an open Postgres connection
  2. Select a DB and choose the Import CSV option
  3. The file is read and the mapping modal window opens
  4. Select to "Import xxx rows into a New table"
  5. Set a new column name to <SKIP>
    • Expected behavior The column type and Null checkbox should be deactivated.
    • Actual result They instead remain editable, but the changes don't stick. The other fields on the list are grayed out.
      1. Set the column title value back to a valid column title
    • Expected behavior The columns become active, editable and have some default values.
    • Actual result The fields appear editable, but the changes don't stick.

Screenshots

https://github.com/hankinsoft/SQLPro/assets/51084/9f9ccd66-74be-4b5b-a997-01a4a93c5de5

Environment details (please complete the following information):

hankinsoft commented 1 year ago

Investigating now. Sorry for the delay, where I live (Nova Scotia Canada) has been in a state of emergency the last few weeks due to wildfires and are just calming down this week. Should have a fix by early next week.

gabriel-r commented 1 year ago

No rush, take care of yourself and close ones!

hankinsoft commented 1 year ago

A fix has been pushed to setapp and should be available in ~24 hours or so. If you get the chance, please give it a try when you see the update and let me know if that sorts things out.

gabriel-r commented 1 year ago

Works a lot better, thanks!

Disclaimer: I only tested the UI and didn't run the actual import, but I don't expect that to have changed.