Clan icons and a few other bugs

[GoogleCodeExporter]

Clan icons are not shown despite they are present, win chance is over the team 
table not above it.
After battle damage done by spoting and by you is not shown same goes for the 
fired shots and hit ratio(maby this is missing).
Credit left on the battle resault is not calculated to shown what you have left 
after expences.

Original issue reported on code.google.com by Soc...@gmail.com on 12 Sep 2013 at 12:08

[GoogleCodeExporter]

>Clan icons are not shown despite they are present
Where?

>win chance is over the team table not above it
Normally.

All functions in hangar in development.

Original comment by mr.a.on...@gmail.com on 12 Sep 2013 at 1:44

[GoogleCodeExporter]

For clan icon issue you need to rename the EU folder to EN to work correctly. 
Maybe temporarily. XVM read the region from version.xml and it contains that 
string.

Original comment by drhide...@gmail.com on 12 Sep 2013 at 3:41

[GoogleCodeExporter]

Hm, we need to move all our resources to EN, because we will use version.xml 
further.

Original comment by m.schedr...@gmail.com on 12 Sep 2013 at 9:49

[GoogleCodeExporter]

Issue 509 has been merged into this issue.

Original comment by maca.pa...@gmail.com on 13 Sep 2013 at 3:50

[GoogleCodeExporter]

Sirmax, any changes except r2592?

Original comment by mr.a.on...@gmail.com on 13 Sep 2013 at 4:48

• Changed state: Started

[GoogleCodeExporter]

US -> NA afair

Original comment by m.schedr...@gmail.com on 13 Sep 2013 at 4:50

[GoogleCodeExporter]

Thanks for the replay.
Changed the name of the clan icons and worked.
Weird bug on the loading battle screen win chances text is in russian then 
after the loading is done changes to english.

Original comment by Soc...@gmail.com on 18 Sep 2013 at 12:11

[GoogleCodeExporter]

>Weird bug on the loading battle screen win chances text is in russian then 
after the loading is done changes to english.

not sure if test2 version have this fixed, but should be ok after r2604

Original comment by maca.pa...@gmail.com on 18 Sep 2013 at 9:14

[GoogleCodeExporter]

Hi All,

Just wanted to provide some feedback of my solution for any other US/NA server 
players who are also having problems getting their clan icons working with XVM 
5.0.0-test2 (WoT client 0.8.8).

Until a short while ago I was *unable* to get XVM to display the clan icons in 
BattleLoading screen, Statistic Form (pressing Tab in-battle) screen or the 
in-battle Player Panels. After much experimentation and gnashing of teeth I 
have solved it for my installation, at least.

I renamed my
"...\res_mods\xvm\res\clanicons\US" folder to
"...\res_mods\xvm\res\clanicons\EN"

Based on the notes contained in @xvm.xc I previosuly tried renaming the 
clanicons folder 'US' -> 'NA' but that didn't work. I then noticed a reference 
in this thread to version.xlm (contained in C:\Program Files\World_of_Tanks on 
my machine). My file shows 'EN' localization (i.e. English language). On a 
hunch, I renamed my clanicons folder to 'EN' and voila, it worked!

So, it looks like XVM is currently using a player's Game Language as the basis 
for recognising the clanicons folder, rather than the previous approach of 
using the player's Game Region. Note sure whether this is a bug or if it is 
part of XVM's evolution. Perhaps a dev can chime in and provide some clarity?

Hope this helps any others who are also stumped.

BTW, if this is part of a new approach, then may I suggest altering the notes 
in the ReadMe file of the ClanIcons download packages?

Thanks for all your hard work XVM Dev Team. I would be lost without this great 
tool.

Cheers!

Original comment by damo1...@gmail.com on 21 Sep 2013 at 12:04

[GoogleCodeExporter]

Since r2693 it should be OK without renaming. 

Original comment by mr.a.on...@gmail.com on 24 Sep 2013 at 9:30

[GoogleCodeExporter]

the "Chance to Win" being in Russian on the battle loading screen is an issue 
for me as well. Found the cause.

It's pulling the text from the RU localization file instead of the EN one.

Original comment by realityb...@gmail.com on 2 Oct 2013 at 8:52

[GoogleCodeExporter]

Original comment by mr.a.on...@gmail.com on 3 Oct 2013 at 4:08

• Changed state: Fixed

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

SEA clanicon won't show up unless rename the 
folder"...\res_mods\xvm\res\clanicons\SEA" to 
"...\res_mods\xvm\res\clanicons\SG", perhaps next clanicon pack can update the 
name of folder or change gameregion.py:
    "elif 'worldoftanks.asia' in _updateurl:
        region = 'SG'"
to:   
    "elif 'worldoftanks.asia' in _updateurl:
        region = 'SEA'"

Original comment by quincy66...@gmail.com on 1 Nov 2013 at 7:35