hanklords / flickraw

Ruby library to access flickr api.
http://hanklords.github.com/flickraw/
MIT License
507 stars 98 forks source link

moves the global flickr helper method to a module #92

Closed jkraemer closed 6 years ago

jkraemer commented 8 years ago

The gem shouldn't declare a global flickr method by default. I moved it to a helper module which can be included where necessary.

hanklords commented 8 years ago

I do not like this : it will break people code. The flickr helper is not causing any problem (as far as I know). Even if your solution is better if it had been like that from the begining,

jkraemer commented 8 years ago

It doesn't cause problems per se of course, but adding methods to Object just for convenience is generally considered bad coding style. Maybe merge it this whenever you release a new major version?