hanlunli / student

MIT License
0 stars 0 forks source link

Individual Review #6

Open hanlunli opened 8 months ago

hanlunli commented 8 months ago

link to blog

IshanCornick commented 8 months ago

1.0/1 - Meets almost all requirements except two tiny parts, goes above and beyond on parts

For one Hanlun is missing one tiny part, he didn't show one or more parameter. Hanlun showed me this separate for his blog so I should be easy to add a picture of this. Also it would be better to show the output code alone with the output being shown on the website so users can understand which part below with each part of code. Also Hanlun's video is a YouTube video which goes against CPT requirements. I asked Hanlun about this and he said it is a YouTube video for easy access but he has a .mp4 file ready for college board.

Hanlun seems to have everything and went above and beyond on parts like his video where he showed high understanding of his sqlite.db files and how everything is connected. His blog has everything but nothing is above and beyond.

Hanlun seems to have everything but could add a few things to go above and beyond. Hanlun can add his commits and exactly what he did for each part of the project. This could help college board graders and others see what parts he is highly knowledgeable about. Hanlun could also make his page a bit more readable with tables.

Overall Hanlun's blog along with video show high understanding of the cpt requirements and meets requirements but is missing a few things.

jm1021 commented 8 months ago

I can't get to link on Hanlun's stuff above.

hanlunli commented 8 months ago

Oops, I linked localhost on accident, it should be fixed now. Sorry for the inconvenience

jm1021 commented 8 months ago

Regarding video. I don't like the placement of the Captions, plus they are to much to read while you are click.

  1. Observe Data, aka Collection - This would be my fist Caption. I would suggest coming up with your own names like Billy Baker and Mary Master Chef. This will help get your people in personality.
    1a. See saved recipe(s). Arrow or perhaps Zoom data of interest.
  2. Input new Recipe - This would be my 2nd Caption. This is where you go to baker and animation. 2a. Observe ingredients in Oven. Do this before Bake.
  3. See Output - Arrow to the croissant
  4. Review Data Update.

If you need to change system where there is a blank space for Captions, that would be wise.

jm1021 commented 8 months ago

1.0/1 - Meets almost all requirements except two tiny parts, goes above and beyond on parts

For one Hanlun is missing one tiny part, he didn't show one or more parameter. Hanlun showed me this separate for his blog so I should be easy to add a picture of this. Also it would be better to show the output code alone with the output being shown on the website so users can understand which part below with each part of code. Also Hanlun's video is a YouTube video which goes against CPT requirements. I asked Hanlun about this and he said it is a YouTube video for easy access but he has a .mp4 file ready for college board.

Hanlun seems to have everything and went above and beyond on parts like his video where he showed high understanding of his sqlite.db files and how everything is connected. His blog has everything but nothing is above and beyond.

Hanlun seems to have everything but could add a few things to go above and beyond. Hanlun can add his commits and exactly what he did for each part of the project. This could help college board graders and others see what parts he is highly knowledgeable about. Hanlun could also make his page a bit more readable with tables.

Overall Hanlun's blog along with video show high understanding of the cpt requirements and meets requirements but is missing a few things.

Ishan you are paragraphing and generalizing with your comments. I would like to see them more like what I shared. This is "real" feedback. The owner of code can adapt to meet CB objectives. But we need to be strong in our opinions. Truly, this is the basis of effective collaboration.

IshanCornick commented 8 months ago

In-depth review of code screenshots: