hanluong
commented
10 months ago Hi Mike,
I’m very happy to correct these issues and improve my code in review process with you but I can’t start right now because I have some personal reasons in this weekend. Can I start to review and responses issues on Monday?
Thank you so much, Han Luong
Vào Th 7, 28 thg 10, 2023 lúc 14:07 Pham Le Minh @.***> đã viết:
Hello Han 👋 , thank you for your effort on the code submission. I am Mike, Engineering Lead at Nimble, and I am happy to be the reviewer for our code review session.
During the review process, I would like to know more about your decisions, so I will create issues in some areas where there could be more improvements regarding your submission. Since solving every possible problem would take too long, I will prioritize the most important ones.
At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to ask questions or share your opinions about the implementation (if any) during the process.
We expect the code review process to be completed within 2-3 days. As a result, please make sure you are responsive during this process. If you need more time, please let us know as soon as possible so we can plan accordingly.
If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. Just so you know, you don't have to close any of my created issues after merging your PRs; I will help verify and close them for you once they pass. 😇
In the end, I do hope that you find the process enjoyable. Good luck and happy coding. 🤘
— Reply to this email directly, view it on GitHub https://github.com/hanluong/NimbleiOSChallenge/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQEWOUP2M7KEFUPIPYAPIZLYBSVKDAVCNFSM6AAAAAA6T3D4KCVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3DMNBXGIYTEMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>
minhnimble
Hello Han 👋 , thank you for your effort on the code submission. I am Mike, Engineering Lead at Nimble, and I am happy to be the reviewer for our code review session.
During the review process, I would like to know more about your decisions, so I will create issues in some areas where there could be more improvements regarding your submission. Since solving every possible problem would take too long, I will prioritize the most important ones.
At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to ask questions or share your opinions about the implementation (if any) during the process.
We expect the code review process to be completed within 2-3 days. As a result, please make sure you are responsive during this process. If you need more time, please let us know as soon as possible so we can plan accordingly.
If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. Just so you know, you don't have to close any of my created issues after merging your PRs; I will help verify and close them for you once they pass. 😇
In the end, I do hope that you find the process enjoyable. Good luck and happy coding. 🤘