search

hanm / clang

Mirror of the official Clang GIT repository
Other
2 stars 0 forks source link

Port DPJ Tutorial examples to ASaP (Sections 1-2.3) #10

Closed atzannes closed 11 years ago

atzannes commented 11 years ago

Sections 2.4 onward use arrays and other annotations not supported yet.

hanm commented 11 years ago

Finished porting, with some FIXME left.

Alex, could you review the sample?

hanm commented 11 years ago

Hi Alex,

Thanks for the review and fixes.

I have an inline question here https://github.com/hanm/clang/commit/741bdc788b2513eed68b24a79cdb949aa60a2069

(BTW, do you get any system notification when I did the inline comment on your commit? Still trying to figure out how these notification works.)

atzannes commented 11 years ago

I did see the comment on Links. I just committed some additional code and I will add comments on github

On Wed, Jan 23, 2013 at 4:24 PM, Michael Han notifications@github.comwrote:

Hi Alex,

Thanks for the review and fixes.

I have an inline question here 741bdc7https://github.com/hanm/clang/commit/741bdc788b2513eed68b24a79cdb949aa60a2069

(BTW, do you get any system notification when I did the inline comment on your commit? Still trying to figure out how these notification works.)

— Reply to this email directly or view it on GitHubhttps://github.com/hanm/clang/issues/10#issuecomment-12626201.

atzannes commented 11 years ago

The only thing that remains to be fixed is dealing with the implicit copy constructor.

atzannes commented 11 years ago

Dealing with implicit functions is a different issue. The DPJ tutorial is successfully ported.