search

hanmekim / SceneLib2

SceneLib2 is an open-source C++ library for SLAM originally designed and implemented by Professor Andrew Davison at Imperial College London.
Other
359 stars 198 forks source link

minor bug fix #8

Closed zhilongyang closed 10 years ago

zhilongyang commented 10 years ago

Both line 83 and 92 should delete the ".format"， i.e. from if (!video->PixFormat().format.compare("YUV422P")) to if (!video->PixFormat().compare("YUV422P")). It cannot compile with ".format", since "video_->PixFormat()" is std::string format and should be followed by ".compare()" directly.

hanmekim commented 10 years ago

Hi, thank you for your contribution, but these changes were made by the recent commit to support the latest Pangolin library and C++11. Please upgrade your Pangolin, and it should work.

hanmekim commented 10 years ago

Or, if you want to keep using the current set-up without taking a risk of the upgrade, please stay with the commit version e9bb44bfe6.

zhilongyang commented 10 years ago

Hi Hanme,

Many thanks for your reply. I have one question about the cam.kd1 parameter, I noticed you have modified it from 9e-06 to 1e-12 for Logitech V-U0009 now, could you please teach me how to compute that? I'm trying to use the Kinect as the camera input now.

Thanks, Zhilong

Zhilong Yang

DPhil Candidate in Computer Science Department of Computer Science | Keble College University of Oxford

Academic Email: zhilong.yang@cs.ox.ac.uk

2013/12/27 Hanme Kim notifications@github.com

Hi, thank you for your contribution, but these changes were made by the recent commit to support the latest Pangolin library and C++11. Please upgrade your Pangolin, and it should work.

— Reply to this email directly or view it on GitHubhttps://github.com/hanmekim/SceneLib2/pull/8#issuecomment-31253030 .

hanmekim commented 10 years ago

Hi Zhilong,

I changed the parameter by looking at the undistorted image. I really would like to do it properly, but as you understand, it is very difficult to find some time while doing PhD, huh? :( Maybe, in the near future, I will change those parameters and add a new calibration tool for SceneLib2. But, now, doing it manually is the only option, sorry.

Many thanks, Hanme

On 6 January 2014 01:36, zhilongyang notifications@github.com wrote:

Hi Hanme,

Many thanks for your reply. I have one question about the cam.kd1 parameter, I noticed you have modified it from 9e-06 to 1e-12 for Logitech V-U0009 now, could you please teach me how to compute that? I'm trying to use the Kinect as the camera input now.

Thanks, Zhilong

Zhilong Yang

DPhil Candidate in Computer Science Department of Computer Science | Keble College University of Oxford

Academic Email: zhilong.yang@cs.ox.ac.uk

2013/12/27 Hanme Kim notifications@github.com

Hi, thank you for your contribution, but these changes were made by the recent commit to support the latest Pangolin library and C++11. Please upgrade your Pangolin, and it should work.

— Reply to this email directly or view it on GitHub< https://github.com/hanmekim/SceneLib2/pull/8#issuecomment-31253030> .

— Reply to this email directly or view it on GitHubhttps://github.com/hanmekim/SceneLib2/pull/8#issuecomment-31622208 .