search

hanmin0822 / MisakaTranslator

御坂翻译器—Galgame/文字游戏/漫画多语种实时机翻工具
GNU General Public License v3.0
4.8k stars 427 forks source link

use correct framework #325

Open kasperk81 opened 7 months ago

kasperk81 commented 7 months ago

netcoreapp was replaced with net since v5.

kasperk81 commented 7 months ago

@hanmin0822 i believe the build is fixed with better (sdk-style) condition which is already used in Directory.Build.targets

unlsycn commented 7 months ago

I'll merge this PR in a week if no one else has a problem.

imba-tjd commented 7 months ago

emmm AndromedaMelody的意思是不改 他说fx和core引的包不同，后面要区分，csproj里又拿不到TargetFrameworkIdentifier。所以不能改

kasperk81 commented 7 months ago

TargetFrameworkIdentifier is certainly available in csproj. check this out: https://github.com/search?q=TargetFrameworkIdentifier+path%3A*csproj&type=code and your CI fails if there was any problem with the package