hannahdxz / STAT545-hw-Dong-Xinzhe

0 stars 0 forks source link

hw05 ready for grading #4

Open hannahdxz opened 6 years ago

hannahdxz commented 6 years ago

738c553 https://github.com/hannahdxz/STAT545-hw-Dong-Xinzhe/blob/master/hw05/hw05.md

gbraich commented 6 years ago

Hello,

Nicely organized README, it was easy to the find the md file.

Factor management This part of the assignment was done well and way easy to follow. Oceania was dropped, and Gapminder country levels were reordered by min. life expectancy. You were able to show that arrange has no effect on plotting unordered data. It wasn't clear what was attempted by using arrange and factor reordering, the aim would have been to arrange in a way that would be different from the reordered plot (descending minimum life expectancy instead of ascending). More commentary here would have been helpful.

File I/O Saving using csv and rds were performed and the differences between the two in terms of data import and factor levels were explained well.

Visualization design An old plot was made to look much better using facet wrap, colour brewer and themes. Great job on going above and beyond and using the multi-plot function. Very useful for juxtaposing and I hope to incorporate it in the future!

Writing Figures to File Using a raster and a vector format would have been good. I see different width and heights were used, playing around with resolution and scale would have also been good. Well done on embedding the image. Using explicit provision of the plot object was explained but not demonstrated.

But I want to do more Great job on using filter, mutate and factor recode to add a new column to your data frame which included popular sports of three countries. Use of the select function would have been helpful here to get rid of extra columns.

Clean up your repo Great job on revamping your top-level README with links to all the submissions, informative titles on the homework and information on the different assignments. I did notice that homework assignments 1-4 were not rerendered.

Overall Great job! The assignment was very easy to follow and looked excellent. Using knit::kable was nice for table viewing!

rainerlempert commented 6 years ago

Hiya,

Nice job on the assignment! Your repo is divine - oh so organized. And beautiful! I could find everything with ease. Your markdown file is also beautiful! I love the attention to detail you place on everything. Other than that, here are a couple comments on your actual assignment:

Factor management

File I/O

Visualization design

Writing figures to file

But I want to do more!

Again, nice work. Way to cap off your time in 545! Rainer

derekcho commented 6 years ago

Hi @hannahdxz! Here are some comments about your hw05:

Note: your mark (check minus, check, check plus) will be distributed later.