search

hannahhoward / a1atscript

The Angular 2 Polyfill
MIT License
101 stars 7 forks source link

Prevent usage of both attr and bind-attr on a component's element #9

Closed timkindberg closed 9 years ago

timkindberg commented 9 years ago

This commit fixes an issue introduced by Angular 1.4.1 where using bind-attr attribute on a component element was overwritten with undefined by the unused non-bind attr.

Fixes #8

timkindberg commented 9 years ago

Not sure why its failing. We ran our tests locally and they passed? Would love to have this merged if you can figure out why Travis is failing!

timkindberg commented 9 years ago

So we pushed the bug fix plus test, but then realized we need to generate the dist files. We tried npm run dist and also a couple of the gulp commands but none seemed to generate the regular dist files. They files output always seemed to go to dist/cjs or build. ac3ac87 no longer exists because we force-pushed, but should not be merged.

hannahhoward commented 9 years ago

Thanks a lot. I finished off the dist generation myself. I'm not sure why you were having trouble.

timkindberg commented 9 years ago

Thanks! It's probably just user error. It was a long stressful day (other problems going on)!

And thanks again for the great library. Really enjoying it. On Fri, Jun 19, 2015 at 4:57 PM Hannah Howard notifications@github.com wrote:

Thanks a lot. I finished off the dist generation myself. I'm not sure why you were having trouble.

— Reply to this email directly or view it on GitHub https://github.com/hannahhoward/a1atscript/pull/9#issuecomment-113642581 .

  • Tim
timkindberg commented 9 years ago

If you had any time to put together a short contrib doc, I'd be sure to reference it next time I contribute :)