Make the "client connected" pre-check valid

[FJEagle]

This reverts commit 39e5ed4a5fe425d4baf6248cf582574e84656db2.

Why reverted?

The commit caused 2 problems:

Problem 1:

run in coroutine, make the "client connected" pre-check might not valid anymore when it runs, therefore the underlying sendNoWait 'client connected' check not matched causing the following exception:

Problem2:

run in coroutine, make the "sendToken" assignment-and-return invalid, it may always return null outside coroutine.

[FJEagle]

@hannesa2 could you help why check failed, I just revert the previous commit

[hannesa2]

yes, this sendToken is an issue. Thank you for pointing this out. I try with https://github.com/hannesa2/paho.mqtt.android/pull/628 an other way to solve it

[FJEagle]

yes, this sendToken is an issue. Thank you for pointing this out. I try with #628 an other way to solve it

628 should have solved problem 2 ,how about problem 1?

Run in coroutine might cause the underlying sendNoWait 'client connected' check not matched, results in throwing exception(32104)， and then crash.

This exception seems not able to be caught in external business when call the publish method since it runs in coroutineScope

[hannesa2]

Maybe I don't really understand the issue exactly. Please can you point me to

the 'client connected' pre-check

that we'll speak about the same

[FJEagle]

here are two screenshots:

the 'client connected' pre-check:

the underlying sendNoWait 'client connected' check and exception throw:

[hannesa2]

Please can you rebase to be able to merge ? I renamed confusing stuff before

[FJEagle]

ok, I'll do it, please wait for a while

[hannesa2]

Which version are you using ?

[FJEagle]

Which version are you using ?

4.3.beta2

[hannesa2]

https://github.com/hannesa2/paho.mqtt.android/releases/tag/4.3.beta3

[FJEagle]

https://github.com/hannesa2/paho.mqtt.android/releases/tag/4.3.beta3

Thanks.

But it seems there are some errors in jitpack:

[hannesa2]

I re-triggered the build, now it's ok