hannesmann / vanillafixes

Client modification for WoW 1.12.1 to eliminate stutter and animation lag
MIT License
132 stars 15 forks source link

Launch the game maximised if shortcut properties say so #19

Closed wodim closed 12 months ago

wodim commented 1 year ago

You can create a shortcut to wow.exe and configure it to launch maximised in the shortcut properties sheet. If you do that in the vanillafixes.exe shortcut, it doesn't work; the wow window is created restored. I know it's not a "bug" in the traditional sense of the word but it would be nice if it worked.

hannesmann commented 1 year ago

Not sure if this can be fixed. I assume Windows is looking for a window created by VanillaFixes.exe, but since the launcher exits and launches WoW.exe the shortcut properties aren't carried over.

wodim commented 1 year ago

You can use GetStartupInfo, and from the STARTUPINFO structure get the wShowWindow member and put it here https://github.com/hannesmann/vanillafixes/blob/d9242b23889d4123aedb74ea4e1e4b969ef8ab8b/src/launcher/launcher.c#L44

(I haven't tested this, I just did some googling)

hannesmann commented 1 year ago

Makes sense, I think you could use the nCmdShow parameter of wWinMain too. I'll look into this later but if you want to fix it I'll accept a PR.

wodim commented 1 year ago

I would've liked to send a PR but setting up the build environment would take me some time for a minor fix like this :) Thanks for looking into it.

hannesmann commented 1 year ago

I haven't tested this but it should work: https://github.com/hannesmann/vanillafixes/raw/shortcut-properties/bin/VanillaFixes.exe

wodim commented 1 year ago

Works fine. Thank you

WuVenus commented 3 months ago

I haven't tested this but it should work: https://github.com/hannesmann/vanillafixes/raw/shortcut-properties/bin/VanillaFixes.exe

cannot open