search

hannesmann / vanillafixes

Client modification for WoW 1.12.1 to eliminate stutter and animation lag
MIT License
132 stars 15 forks source link

Fix the 1 second black screen bug #35

Closed Zebouski closed 7 months ago

Zebouski commented 8 months ago

I personally use Linux but I hear windows users have been suffering from the dxvk version of VF with the screen going black every time they alt tab in and out of the game. Someone today found this config setting resolves this issue, and I've had multiple people test this config change and confirm the problem is indeed solved.

Ge3e commented 8 months ago

I can 2nd this. My whole screen goes black for 1-2 seconds when moving mouse out of window. It never did this before. I have only noticed it since NVIDIA updated their driver to 546.01 prior to this I had no issues. In addition to this I have had a massive FPS drop in general V Synced to 60FPS but only hovers around 40 FPS in world. I have a RTX 4070 so its not my card.

ericschn commented 8 months ago

I can confirm this is working on RTX 3080 with 536.23 driver. Also works fine on GTX 970, but the issue wasn't present on that card in the first place.

hannesmann commented 8 months ago

The setting d3d9.enableDialogMode disables exclusive fullscreen. You should be able to get the same effect by setting the game to windowed mode and enabling "Maximized".

For any NVIDIA users on Windows, does changing this setting to "Prefer native" in the control panel solve the issue?

Ge3e commented 8 months ago

I can confirm this is working on RTX 3080 with 536.23 driver. Also works fine on GTX 970, but the issue wasn't present on that card in the first place.

I had not issues with the 536.23 driver only latest ones eg 546.01

Ge3e commented 8 months ago

The setting d3d9.enableDialogMode disables exclusive fullscreen. You should be able to get the same effect by setting the game to windowed mode and enabling "Maximized".

For any NVIDIA users on Windows, does changing this setting to "Prefer native" in the control panel solve the issue?

Hi @hannesmann, unfortunately no. I just tried it now.

Ge3e commented 7 months ago

@Zebouski your dxvk.conf file seems to have fixed the issue. Thanks.

Ge3e commented 7 months ago

Still have low FPS though on an ASUS 4070 RTX - i9 9900k. With everything maxed out I get 40-55 FPS. Should be couple of hundred at least.

hannesmann commented 7 months ago

Hi @hannesmann, unfortunately no. I just tried it now.

Hmm, well I'm not sure what else could have changed in a driver update (you could try the other option too). I don't want to merge this because it would disable exclusive fullscreen for AMD/Intel users but I updated the guidance on the releases page to mention the fix.

Still have low FPS though on an ASUS 4070 RTX - i9 9900k. With everything maxed out I get 40-55 FPS. Should be couple of hundred at least.

Could you try removing DXVK (d3d9.dll) and see if that helps?

Zebouski commented 7 months ago

Hmm, well I'm not sure what else could have changed in a driver update (you could try the other option too). I don't want to merge this because it would disable exclusive fullscreen for AMD/Intel users but I updated the guidance on the releases page to mention the fix.

Thanks, I didn't know this was an issue only affecting nvidia+windows, and that going borderless full windowed does the same thing as this config value. I've updated the turtle wow wiki to direct people to your instructions. I think you can close this PR now and move people to a github issue for further troubleshooting.

But yeah from what I've heard from others, I thought the general recommendation these days for 1.12 was to not use exclusive fullscreen at all? Or is that another thing that is only an issue for certain brand hardware?

hannesmann commented 7 months ago

I thought the general recommendation these days for 1.12 was to not use exclusive fullscreen at all?

The last time I tried it exclusive fullscreen was the only way to get FreeSync working on AMD. Since this bug only seems to have appeared with 546.01 I'll assume it's an issue specific to NVIDIA for now.

Closing in favor of #36