hannesmannerheim / qvitter

mirror. moved to https://git.gnu.io/h2p/Qvitter, send merge requests and issues there
https://git.gnu.io/h2p/Qvitter
GNU Affero General Public License v3.0
86 stars 26 forks source link

URL shortener fails to detect certain URLs under certain conditions #135

Closed deutrino closed 9 years ago

deutrino commented 9 years ago

Often, the URL shortener in Qvitter will fail to detect some URLs if they are pasted after a colon. This may happen under other circumstances as well.

In the following screenshot, I've typed lol hehe: (including a space after the colon) and then pasted a URL, which is misdetected and does not activate the URL shortener button.

If I add and delete a second space after the colon, or if I delete the colon, the URL will be detected correctly and the shortener button will activate.

qvitterurl01

hannesmannerheim commented 9 years ago

i can reproduce this in safari browser, but not firefox. safari adds a "non breaking space" instead of a regular space after the colon, for some reason. should be easy to fix!

hannesmannerheim commented 9 years ago

is it working for you on quitter.se now?

deutrino commented 9 years ago

It failed this morning (on a quitter.se test account) when I pasted a different URL after a quotation mark. The same "add and delete a space" workaround also worked in that case. Now I can't reproduce that bug either, but I hadn't refreshed the browser at that time.

hannesmannerheim commented 9 years ago

if you hadn't refreshed that explains it. closing this, but feel free to open it if you see it again!

deutrino commented 9 years ago

Thank you for the fix! :)