hannesmannerheim / qvitter

mirror. moved to https://git.gnu.io/h2p/Qvitter, send merge requests and issues there
https://git.gnu.io/h2p/Qvitter
GNU Affero General Public License v3.0
86 stars 26 forks source link

"Follows you" sometimes is not shown ["follows you" badge for remote profile popup] #178

Closed moshpirit closed 9 years ago

moshpirit commented 9 years ago

I get the notification: "someone has follow you" so I click on the username of this "someone", the profile resume is shown but not the "follows you" message. Then I think: OK, maybe (s)he stopped following me, but then, I check out the people that (s)he's following and I'm there.

It recently happened with loadaverage.org, social.mxchange.org, micro.fragdev.com, gnusocial.net and indy.im. With people of my own server works perfectly as I've seen.

Checked on quitter.es and status.vinilox.eu

hannesmannerheim commented 9 years ago

not all instances display the so called "activity notices", e.g. quitter.se. i don't know about the others. in that case it's just like you describe, it's only visible in your notifications and in their followers.

but i noticed that twitter recently started displaying recent followings on peoples profiles, so maybe we should do that in qvitter aswell, i'm not sure what i think.

moshpirit commented 9 years ago

I think I didn't describe it well. What I meant is:

A follows B B get a notification and check A's profile Then, B see in the A's resume (name, bio, activity and last note) a message: "follows you"

This message is the one that I could a few weeks ago, and not now

hannesmannerheim commented 9 years ago

i understand. maybe the admin disabled activity notices, or there's been some change in gnusocial removing them. or there is a bug that's causing them not to be created or shown.

i don't think it has to do with qvitter.

hannesmannerheim commented 9 years ago

hm, but there is one outputted in your profile skarmavbild 2015-05-22 kl 12 51 32

hannesmannerheim commented 9 years ago

and this user produced an activity notice when following you 2 days ago: skarmavbild 2015-05-22 kl 12 52 57

moshpirit commented 9 years ago

No, it's not this kind of activity, I mean the resume of an account, what I see when I click on another profile: photo and background, queets, following, groups and the last one queet.

I'm not in home, I'll post later a picture.

hannesmannerheim commented 9 years ago

my screenshots are from the profile! from quitter.es/moshpirit and quitter.es/allanviega

hannesmannerheim commented 9 years ago

oh, now i understand.

hannesmannerheim commented 9 years ago

the "profile popup"/resume/summary is only for remote users, not local. and whether or not the "started following X" activity notice shows as the last notice depends on the remote instance. if the remote instance has activity notices turned on and the activity is the latest notice.

hannesmannerheim commented 9 years ago

example from quitter.es displaying an indy.im user skarmavbild 2015-05-22 kl 13 15 43

moshpirit commented 9 years ago

Exactly :D excuse me if I didn't explain myself correctly, maybe I should post some photo before I went out

hannesmannerheim commented 9 years ago

ohh! NOW i think i understand! sorry. the small "follows you" badge beside the username is missing from the profile popup.

that is correct, but it has actually never existed for remote users in the profile popup. i have that as a feature on the todo list.

hannesmannerheim commented 9 years ago

so, you did most certainly not have that a few weeks ago.

moshpirit commented 9 years ago

Mm now I see... I didn't know it wasn't implemented. Ok thank you very much!!

hannesmannerheim commented 9 years ago

sorry for being stupid and slow to understand!

moshpirit commented 9 years ago

Haha, yes, I thought I saw it before in other instances popup, in fact, this pop up only is shown for other instances, isn't it?

moshpirit commented 9 years ago

Don't worry, next time I'll post a screenshot :-) thanks for your work!

hannesmannerheim commented 9 years ago

yep, it's only for remote instances. but i think i will make it for all users, even local users. now you don't know if clicking a user will open a popup or switch page, which is not good.

moshpirit commented 9 years ago

Perfect :-) I think I remember I asked you for this change

moshpirit commented 9 years ago

BUG REPORT

First, thanks for the works! the feature is really cool! but I've found a bug, when I click on her username from notifications, it doesn't show the popup of her profile, but mine.

zzzzzzzzzzz

I've just checked it directly from her profile and it works perfectly. I've been testing a little more and realized that it happens only with notifications from users using quitter.es (the instance I use)edit: when they mark as favourite or share a note.

Should I open a new issue? if not, thanks again and see you on GS (and here)! :)

Edit: OK, it doesn't work perfectly I can't see all of her 27 posts :( but that only happened with her.