hannesmannerheim / qvitter

mirror. moved to https://git.gnu.io/h2p/Qvitter, send merge requests and issues there
https://git.gnu.io/h2p/Qvitter
GNU Affero General Public License v3.0
86 stars 26 forks source link

[Language Menu] Add U+200E LEFT-TO-RIGHT MARK character after U+0029 RIGHT PARENTHESIS #205

Closed GreenLunar closed 9 years ago

GreenLunar commented 9 years ago

Add ‎ tag after ) to avoid português (Brasil) being displayed like this (português (Brasil.

hannesmannerheim commented 9 years ago

hm, it's not displayed like that when i select a RTL language. is there's a browser setting that makes this happen?

GreenLunar commented 9 years ago

No, this is what happens when you have a neutral character (character that has no direction set) at the end of a string (i.e. the direction set on page, determines the direction of that neutral character), and for these cases you have Unicode Control Characters such as LRM (that is, U+200E LEFT-TO-RIGHT).

GreenLunar commented 9 years ago

Did you open Language Menu in RTL locale?

hannesmannerheim commented 9 years ago

yes

hannesmannerheim commented 9 years ago

skarmavbild 2015-06-18 kl 17 51 52

hannesmannerheim commented 9 years ago

would be interesting to know what browser setting that causes it

GreenLunar commented 9 years ago

bad_right_parenthesis

GreenLunar commented 9 years ago

would be interesting to know what browser setting that causes it

Maybe it is fixed in latest git version?

hannesmannerheim commented 9 years ago

no, i just tried it on quitter.se and it's the same

GreenLunar commented 9 years ago

AHA! That menu direction is always set to LTR.

I see that ! is misplaced, הזמינו חברים! instead of !הזמינו חברים. I can add ‏ in translation file instead.

Also @; hannes@ instead of @hannes.

hannesmannerheim commented 9 years ago

quitter.se is updated with latest qvitter btw

GreenLunar commented 9 years ago

no, i just tried it on quitter.se and it's the same

You must be logged out.

hannesmannerheim commented 9 years ago

yes! now i see it!

GreenLunar commented 9 years ago

I prefer this menu to follow page direction rather than always being in LTR direction.