hannesmannerheim / qvitter

mirror. moved to https://git.gnu.io/h2p/Qvitter, send merge requests and issues there
https://git.gnu.io/h2p/Qvitter
GNU Affero General Public License v3.0
86 stars 26 forks source link

Qvitter does not save the language preference #219

Closed GPhMorin closed 9 years ago

GPhMorin commented 9 years ago

Even though I log into my account on Quitter.no, the language of the UI is still English while I had previously chosen Ido.

hannesmannerheim commented 9 years ago

it because it saves the language per-user, and "logged out" is counted as it's own user. but i'm going to think of a way to make this more intuitive. thanks!

hannesmannerheim commented 9 years ago

i think i solved this in a intuitive way. it's live now on quitter.se. but you may have to clear the localStorage in your browser to see it work as intended, which can be a little tricky

GPhMorin commented 9 years ago

Is the language setting stored locally or on the server? I use Private Browsing on Firefox and it does not switch to Ido when I log in.

hannesmannerheim commented 9 years ago

works for me with firefox private window also (on .se)

hannesmannerheim commented 9 years ago

but again, you might have to clear the localStorage for this to take effect

hannesmannerheim commented 9 years ago

but if you have some other browser plugin that disabled localStorage, language selection, and a lot of other qvitter features will not work

hannesmannerheim commented 9 years ago

(sorry, to answer your question: it's stored locally, in localStorage)

GPhMorin commented 9 years ago

Wouldn't it be better saved on the server? That way the language would be the same for the user, whatever the browser or computer used. I think that is Twitter's behavior too.

hannesmannerheim commented 9 years ago

there's no support in the gnusocial api for that, we'd have to create a qvitter-specific api which is a little work. also i don't see the point, localstorage is working well, and is needed for a lot of other vital qvitter features too.

GPhMorin commented 9 years ago

Because of that, language switching does not work in Private mode on Mobile Safari.

hannesmannerheim commented 9 years ago

not on desktop safari's private mode either apparently

GPhMorin commented 9 years ago

That's an issue, isn't it? I and other people I know use Private browsing frequently, especially when using someone else's computer.

hannesmannerheim commented 9 years ago

although people don't expect webpages to work flawlessly with private browsing, so it's not a big issue for me. i think this is more of an issue with safari being overly paraniod than with qvitter. remember firefox allow localstorage in private windows. i really like localstorage for privacy reasons just because it means we can deal with stuff locally that the server and the middlemen don't have to know about.

hannesmannerheim commented 9 years ago

although i may implement an error messaging feature that tells the user that localstorage wasn't available and that that will disable a lot of qvitter features

GPhMorin commented 9 years ago

What are those Qvitter features that use localstorage?

hannesmannerheim commented 9 years ago

caching, speeding up the ui and taking load off the server