hannesmannerheim / qvitter

mirror. moved to https://git.gnu.io/h2p/Qvitter, send merge requests and issues there
https://git.gnu.io/h2p/Qvitter
GNU Affero General Public License v3.0
86 stars 26 forks source link

"apple.com" does not become a clickable link #236

Closed GPhMorin closed 9 years ago

GPhMorin commented 9 years ago

Event though "apple.com" and "ido.li" become blue in the message composer, the final Queet does not make them into clickable links.

hannesmannerheim commented 9 years ago

looks like this feature has been removed from gnu social...

hannesmannerheim commented 9 years ago

what do you think, should i try to re-implement the highlighting of links without protocol (http/https), or should i remove the highlighting of such links from the queet composer?

GPhMorin commented 9 years ago

I'll try to answer that in an objective way: I tried writing "apple.com" on Twitter, Facebook and Google+. In all three cases, "apple.com" turned into a blue, clickable link. To make Quitter more intuitive, I would expect the same behavior.

hannesmannerheim commented 9 years ago

yes, i agree. although twitter doesn't make "quitter.se" into a link though. i wonder how they decided which top lever domains to highlight and which not to.

hannesmannerheim commented 9 years ago

i'll see if i can find the commit in gnusocial where it was removed. maybe i can just copy some code from that into qvitter.

hannesmannerheim commented 9 years ago

ah! it had become a setting: $config['linkify']['bare_domains'] = true;

GPhMorin commented 9 years ago

So, is that on a server-level configuration?

hannesmannerheim commented 9 years ago

yes, but i've made that the default behaviour in qvitter now.

GPhMorin commented 9 years ago

Thank you! By "default", does that mean that Quitter.no will enable it too?

hannesmannerheim commented 9 years ago

yes

GPhMorin commented 9 years ago

Good :)