Disable qvitter-delete-notice if ActivityModeration plugin exists

[ghost]

I think this won't cause any problems with older installations. If the GNU social instance is newer and has the ActivityModeration plugin, remote notice deletion is handled through that instead of Qvitter.

[ghost]

Hm, this doesn't seem to hide the delete verb notices though, so there are items like these listed: "<Mikael & Nordfeldth> deleted notice {{tag:social.umeahackerspace.se,2015-10-03:noticeId=280252:objectType=note}}."

[hannesmannerheim]

i'll check it out

[hannesmannerheim]

i updated from nightly, ran upgrade.php and added to config:

addPlugin('ActivityVerb'); addPlugin('ActivityModeration');

but i can't delete notices anymore. i click delete, confirm delete and then i get:

and if i click yes i get

the notice is not deleted, but a delete-activity notice is outputted

[ghost]

On 2015-10-04 13:06, Hannes Mannerheim wrote:

i updated from nightly, ran upgrade.php and added to config:

´ addPlugin('ActivityVerb'); addPlugin('ActivityModeration');

You shouldn't have to add those plugins manually, they are listed in lib/default.php in the $config['plugins']['core'] array.

but i can't delete notices anymore. i click delete, confirm delete and then i get: skarmavbild 2015-10-04 kl 13 03 33

Oh, interesting. Notice_location is in db/core.php so it should be checked and fixed when running upgrade.php

Do you have a notice_location table in that site's database?

Mikael Nordfeldth XMPP/mail: mmn@hethane.se OpenPGP fpr: AE68 9813 0B7C FCE3 B2FA 727B C7CE 635B B52E 9B31

[hannesmannerheim]

oh, ok, i thought it was an opt-in feature?

no, no notice_location table. maybe upgrade.php failed silently

[ghost]

On 2015-10-04 13:40, Hannes Mannerheim wrote:

oh, ok, i thought it was an opt-in feature?

no, no notice_location table. maybe upgrade.php failed silently

I don't think it can fail silently :)

Does scripts/upgrade.php say anything about "moving location data"?

Or maybe an even better question, if you in the mysql/mariadb CLI do:

DESCRIBE notice;

does it list columns like 'lat', 'lon, 'location_id' or 'location_ns'?

In that case, Notice::beforeSchemaUpdate() doesn't get run. Can you make sure that code is in Notice.php and have another look at the output of the upgrade script?

Mikael Nordfeldth XMPP/mail: mmn@hethane.se OpenPGP fpr: AE68 9813 0B7C FCE3 B2FA 727B C7CE 635B B52E 9B31

[hannesmannerheim]

there were errors in the log from upgrade.php, outdated extensions...... trying to fix it. but my consoleophobia is not helping

[hannesmannerheim]

finally got the upgrade script working again! now deleting of notices works :) i'll check why the activity notices are not hidden

[hannesmannerheim]

looks like the activity notice produced is saved with object type http://activitystrea.ms/schema/1.0/note

shoudn't it be http://activitystrea.ms/schema/1.0/activity ?

[hannesmannerheim]

i made qvitter consider the delete-"note":s to be activity notices (that are hidden)