search

hannesmannerheim / qvitter

mirror. moved to https://git.gnu.io/h2p/Qvitter, send merge requests and issues there
https://git.gnu.io/h2p/Qvitter
GNU Affero General Public License v3.0
86 stars 26 forks source link

Check if qvitternotice is >191 and not 255 #296

Closed knut-erik closed 8 years ago

knut-erik commented 8 years ago

The column value in table config is of varchar(191) and not 255 which is the check done for qvittersidenotices...

knut-erik commented 8 years ago

Would be preferrable to have a larger column - to get better sidebar notifications on qvitter :) - html code takes a lot of chars.

knut-erik commented 8 years ago

It was change 12th Feburary 2015 to varchar(191) - don't know why. Don't understand @mmn comment. "varchar(191) not 255 because utf8mb4 takes more space" https://git.gnu.io/gnu/gnu-social/commit/2f86cd860231f92213950d439e9a109b7a5f11c4

Would be nice to have the field to 1024 or something, because HTML takes a lot of char's

hannesmannerheim commented 8 years ago

i suspected it had to do with that. the db was converted to utf8mb4 to enable emoji-support. but why not just have a text field? it's not like the column will be used as a key or index

ghost commented 8 years ago

Just making it a text would be great. Those 255 to 191 changes were mostly made automatically with 'grep' and 'sed' so I made no further analysis of which text fields I was changing (except where I ran into trouble, such as with file URLs where I solved the indexing with a urlhash field).