search

hannesmannerheim / qvitter

mirror. moved to https://git.gnu.io/h2p/Qvitter, send merge requests and issues there
https://git.gnu.io/h2p/Qvitter
GNU Affero General Public License v3.0
86 stars 26 forks source link

QvitterEndShowHeadElements vs EndShowHeadElements #297

Closed singpolyma closed 8 years ago

singpolyma commented 8 years ago

Why does Qvitter have its own hook for this? Wouldn't it make more sense to use the standard event so it will work with more existing plugins?

hannesmannerheim commented 8 years ago

that might add css that is specific for the standard ui, which might break qvitters css

hannesmannerheim commented 8 years ago

also: it would not work as expected in plugins, since i've seen that some plugins check which action is calling the event, and in qvitter's case that is qvitter not showstream for example

singpolyma commented 8 years ago

Hmm, re the specific instanceof checks, that's a good point