hannesmannerheim / qvitter

mirror. moved to https://git.gnu.io/h2p/Qvitter, send merge requests and issues there

https://git.gnu.io/h2p/Qvitter

GNU Affero General Public License v3.0

86 stars 26 forks source link

TypeError: streamObject is undefined #312

Closed hanappe closed 8 years ago

hanappe commented 8 years ago

TypeError: streamObject is undefined stream-router.js:456:0

It seems that function pathToStreamRouter(path) does not return a valid streamObject. The last block at the end of the function "if(window.pluginStreamObjects.length > 0)" returns streamObject if length>0 but nothing is returned when length==0.

Quick fix: // other plugins can add streams to Qvitter if(window.pluginStreamObjects.length > 0) { // ... } // ADDED: return the streamObject return streamObject; }

hannesmannerheim commented 8 years ago

how do i reproduce the bug?

hannesmannerheim commented 8 years ago

i added return false instead, does that solve your problem?

hanappe commented 8 years ago

I did a clean install as follows:

cd /var/ww && git clone https://git.gnu.io/gnu/gnu-social.git --branch nightly --single-branch
create db + db user
mkdir avatars background file
cp htaccess.sample .htaccess; change RewriteBase
chown -R www-data.www-data /var/www/gnu-social
open https://myserver/gnu-social/install.php
cd /var/www/gnu-social; mkdir local/plugins; cd local/plugins; git clone https://github.com/hannesmannerheim/qvitter; mv qvitter Qvitter
edit config.php, copy/paste from https://github.com/hannesmannerheim/qvitter/blob/master/README.md

Note that the GNU Social url contains a directory (https://myserver/gnu-social/...). There seem to be other issues related to that.

On 11/20/2015 11:57 AM, Hannes Mannerheim wrote:

how do i reproduce the bug?

— Reply to this email directly or view it on GitHub https://github.com/hannesmannerheim/qvitter/issues/312#issuecomment-158358558.

hannesmannerheim commented 8 years ago

ok so you mean nothing works? it's not when you do something specific?

hannesmannerheim commented 8 years ago

ah, now i see: "Note that the GNU Social url contains a directory"

qvitter does not support that. i thought i had written it in the readme

hannesmannerheim commented 8 years ago

14

hannesmannerheim commented 8 years ago

sorry for my bad documentation, i have added the info in the readme now.

hanappe commented 8 years ago

Thanks! I'll move the installation.

On 11/20/2015 12:26 PM, Hannes Mannerheim wrote:

sorry for my bad documentation, i have added the info in the readme now.

— Reply to this email directly or view it on GitHub https://github.com/hannesmannerheim/qvitter/issues/312#issuecomment-158367668.