search

hannesmannerheim / qvitter

mirror. moved to https://git.gnu.io/h2p/Qvitter, send merge requests and issues there
https://git.gnu.io/h2p/Qvitter
GNU Affero General Public License v3.0
86 stars 26 forks source link

Only enable qvitter for javascript users #333

Closed ghost closed 8 years ago

ghost commented 8 years ago

Also makes it less problematic that Qvitter doesn't provide metadata everywhere.

The first time a non-logged in user loads the website, javascript will run (or not) that sets a cookie to enable qvitter and reloads the page.

I also made it so that when Qvitter is enabled, it just reloads the same page and doesn't go to your home timeline.

ghost commented 8 years ago

This patch has a bit of a problem remembering which state to be in (i.e. it falls back to qvitter - haven't seen it go the other way though). I wonder if this is because of cached calls which carry the cookies...

Oh well, I don't expect you to blindly accept this anyway, I've got a bit more testing to do :]

ghost commented 8 years ago

I'm switching branches and stuff so it doesn't interfere with my local master

hannesmannerheim commented 8 years ago

i saw it in action on social.umeahackerspace now. first the default ui showed for 2 seconds, then it switched to qvitter. and social.umeahackerspace seems to have qvitter in opt-out mode (enabledbydefault=true) just like quitter.se. that doesn't work for us, sorry!