hannesmannerheim / qvitter

mirror. moved to https://git.gnu.io/h2p/Qvitter, send merge requests and issues there
https://git.gnu.io/h2p/Qvitter
GNU Affero General Public License v3.0
86 stars 26 forks source link

Use media_ids in api upload #350

Closed ghost closed 8 years ago

ghost commented 8 years ago

I want to accept the media_ids parameter from Twitter clients, so I need to do it in prepare (and then use it in handle). Since handle was the only function touched in this call I figured I can just remove all the other ones for now and then we can aim to migrate ApiQvitterStatusesUpdateAction into ApiStatusesUpdateAction :)

hannesmannerheim commented 8 years ago

looks like you removed my "post_to_groups"-argument? i wonder if that will break qvitter's group correction feature

hannesmannerheim commented 8 years ago

maybe better to just route ApiQvitterStatusesUpdate to its own url instead of overwriting GNU social's

hannesmannerheim commented 8 years ago

the group correcting seems broken anyway...

hannesmannerheim commented 8 years ago

no! it's not broken. i just failed to save a file :)

ghost commented 8 years ago

Wups, yes I accidentally removed that! Didn't see. That could've otherwise been solved with:

parent::prepare(); post_to_group_stuff; return true;

But your solution of just having a different path worked just fine too of course!