search

hannesrauhe / lunchinator

Tool to call colleagues for lunch
Other
1 stars 0 forks source link

Should the alarm time be the ready time? #252

Closed hannesrauhe closed 10 years ago

hannesrauhe commented 10 years ago

Should we replace the alarm time? If not, we should at least make sure that there is always alarm when you are ready for lunch.

entropia1 commented 10 years ago

You mean we should remove the no alarm before/after setting and use the free for lunch from/until instead? Is there any special reason to do this? I agree that we should extend the range to cover at least the free time.

hannesrauhe commented 10 years ago

The only reason is to get rid of that setting, because I find it a bit confusing sometimes... If we change that to cover at least the free time, another idea would be to have a checkbox: "alarm only during free time / alarm always"

entropia1 commented 10 years ago

If there is another option like "extend by 30 Minutes", it would be OK for me.

hannesrauhe commented 10 years ago

Sounds reasonable.

hannesrauhe commented 10 years ago

For backward compatibility and out of lazyness ^^ I changed the behavior to sound the alarm in the alarm time and in free-for-lunch-time. Makes sense for me, since I can now have alarm for beer in the afternoon without opening the settings or allowing alarm all day.

Is that ok for you?

entropia1 commented 10 years ago

That's OK.