hannestschofenig / mbedtls

An open source, portable, easy to use, readable and flexible SSL library
https://tls.mbed.org
Apache License 2.0
15 stars 8 forks source link

Move ECP TLS 1.3 handling back to TLS layer #401

Closed lhuang04 closed 1 year ago

lhuang04 commented 1 year ago

Summary: PR 343 refactor introduced some discrepancy in crypto library between tls13-prototype and development branch. However there seems no plan to upstream it back to development branch.

Move the ECP TLS 1.3 handling back to TLS layer. This can remove the crypto library difference between tls13-prototype branch and development branch.

Test Plan:

ssl-opt.sh -p -s -f "TLS 1.3: "

Reviewers:

Subscribers:

Tasks:

Tags:

Notes:

Status

READY/IN DEVELOPMENT/HOLD

Requires Backporting

When there is a bug fix, it should be backported to all maintained and supported branches. Changes do not have to be backported if:

Yes | NO
Which branch?

Migrations

If there is any API change, what's the incentive and logic for it.

YES | NO

Additional comments

Any additional information that could be of interest

Todos

Steps to test or reproduce

Outline the steps to test or reproduce the PR here.

lhuang04 commented 1 year ago

This may no longer be needed. There seems to be no libcrypto difference between development and tls13-prototype. The one left over, ecp_internal.h was also no longer in the latest development branch.