search

hannestschofenig / mbedtls

An open source, portable, easy to use, readable and flexible SSL library
https://tls.mbed.org
Apache License 2.0
15 stars 8 forks source link

TLS13 error codes in ssl.h do not follow the high-level convention #96

Open zhihan opened 3 years ago

zhihan commented 3 years ago

Looking at the code in error.c, all the high-level error codes need to set the last seven bits to be zero (https://github.com/hannestschofenig/mbedtls/blob/4d4fd9cf45435dd23d68227a55c486f07b7d79d2/library/error.c#L222) . However, this is no longer the case for some of the new TLS13 errors.

hanno-becker commented 3 years ago

@zhihan Thank you for spotting this, it's something that will need addressing at the latest when we aim to upstream the respective parts of the prototype.