hannibal002 / SkyHanni

SkyHanni is a Minecraft Mod for Hypixel SkyBlock.
https://discord.gg/skyhanni-997079228510117908
GNU Lesser General Public License v2.1
260 stars 150 forks source link

Bingo Personal Stats Display #206

Open hannibal002 opened 1 year ago

hannibal002 commented 1 year ago

Showing bingo related stats like playtime, death count or god splash time

sync up with /pt handle god splash time gets cut in half after death, show a old -> new time message

HacktheTime commented 6 months ago

a) You no longer loose duration on death. b) Legendary Bingo Pet can boost up to 50% extra Duration c) Maybe read out got pot duration based on Duration on the Player with things like Strength 7 which are shown while in inventory. -> can be read out via the Minecraft.getMinecraft().thePlayer

Edit: While I have no idea how to integrate it properly in the Style this project is in, I have the potion reader:

Would break if you would disable strength for some reason, but that should never be a problem, since why would you ever do that. Strength 6 is maximum from Alixer with rank 4 so I think that should be safe. Strength is a vanilla effect and shown in the inventory and thereby can be tracked. at the same time, strength is an essential potion which is always a part in a god splash.

fun bingoGodPotionDuration(): Int {
        for (activePotionEffect in Minecraft.getMinecraft().thePlayer.activePotionEffects) {
            if (activePotionEffect.potionID.equals(Potion.damageBoost.id)) {
                if (activePotionEffect.amplifier >= 8) {
                    return activePotionEffect.duration
                }
            }
        }
        return 0;
    }
RayDeeUx commented 6 months ago

a smidge of a caveat with your reply, @HacktheTime:

all development-related discussion happens on the skyhanni discord, typically within the #suggestions or #coding channels there. yes, the github issue we're typing our responses in very much exists, but it is mostly for hanni's self-documentation purposes.

anyways, looking forward to your response(s) there—especially for a function that doesn't know/clarify if it's returning the remaining duration duration in minecraft ticks, seconds, or minutes.